-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring iOS build with CMake #3234
Conversation
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3234-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3234-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3234-compared-to-main.txt |
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3234-compared-to-main.txt |
I had to upgrade to the latest CMake, maybe the The Team ID |
@TimSylvester Yes if you use the CMakePresets.json you need CMake 3.31. @TimSylvester That's the one on CI. Yes I'll fix that. |
ios-ci
that builds thembgl-core
,ios-sdk-static
andapp
CMake targets for iOS.platform/darwin/core
to better separate out the iOS SDK.MLN_PUBLIC_IOS_APP_SOPURCE
.CMakePresets.json
. Other platforms will be added in a follow-up PR. Info here: https://martin-fieber.de/blog/cmake-presets/