Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS/macOS observer hooks #3245

Merged
merged 11 commits into from
Feb 27, 2025
Merged

Conversation

adrian-cojocaru
Copy link
Collaborator

@adrian-cojocaru adrian-cojocaru commented Feb 21, 2025

Follow-up to #2694. Adds MapObserver events to iOS/macOS delegates.

Copy link

github-actions bot commented Feb 21, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +22.3Ki  +0.1% +16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3245-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review February 21, 2025 16:56
@adrian-cojocaru adrian-cojocaru self-assigned this Feb 21, 2025
@adrian-cojocaru adrian-cojocaru requested review from louwers, alexcristici and TimSylvester and removed request for louwers February 21, 2025 16:56
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some example usage to the Objective-C and/or Swift based apps?

@acalcutt
Copy link
Collaborator

Do you think this could help troubleshoot #2928 . I was trying to figure out how to troubleshoot the node process crash in xcode but wasn't really sure what hooks to watch for since I have never done it before. Does this add hooks I could watch for?

@adrian-cojocaru
Copy link
Collaborator Author

@acalcutt Using onWillStartRenderingFrame/onDidFinishRenderingFrame might help identify if the problem is inside a frame, but considering your test case has a static map I don't think the existing events will help that much.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Some documentation strings should be added.

@adrian-cojocaru
Copy link
Collaborator Author

Thanks for adding the documentation!

@louwers louwers merged commit ce4dcb7 into maplibre:main Feb 27, 2025
36 checks passed
@adrian-cojocaru adrian-cojocaru deleted the ios-observer-hooks branch March 12, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants