Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tqdm autonotebook for tqdm #501

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Use tqdm autonotebook for tqdm #501

merged 2 commits into from
Sep 12, 2024

Conversation

rwood-97
Copy link
Collaborator

Summary

This PR makes all imports for tqdm using tqdm.autonotebook.
This should work in google colab.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 added the no changelog For PRs which don't require changelog updates label Sep 11, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/spot_text/runner_base.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 65.89% <85.71%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/classify/classifier.py 64.96% <ø> (ø)
mapreader/download/sheet_downloader.py 79.01% <100.00%> (ø)
mapreader/download/tile_loading.py 82.53% <100.00%> (+3.17%) ⬆️
mapreader/download/tile_merging.py 84.50% <100.00%> (+8.45%) ⬆️
mapreader/load/images.py 74.47% <100.00%> (+0.24%) ⬆️
mapreader/process/context_post_process.py 98.55% <100.00%> (ø)
mapreader/process/occlusion_analysis.py 99.23% <100.00%> (ø)
mapreader/spot_text/runner_base.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@rwood-97 rwood-97 merged commit 3db8e6f into main Sep 12, 2024
8 checks passed
@rwood-97 rwood-97 deleted the tqdm_autonotebook branch September 12, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog For PRs which don't require changelog updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant