Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix explore methods #544

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Bug fix explore methods #544

merged 2 commits into from
Jan 3, 2025

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Jan 3, 2025

Summary

This fixes a bug in the explore_predictions and explore_search_results methods caused by having both pixel and geo coordinates in our geodataframe.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 added the bug Something isn't working label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/spot_text/runner_base.py 0.00% 2 Missing ⚠️
Flag Coverage Δ
unittests 78.96% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/spot_text/runner_base.py 79.02% <0.00%> (-0.39%) ⬇️

@rwood-97 rwood-97 merged commit 1c98024 into main Jan 3, 2025
9 of 10 checks passed
@rwood-97 rwood-97 deleted the explore_fix branch January 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant