fix(ts): flawed boolean logic

marko-js · Jan 9, 2025 · b87f4b2 · b87f4b2
1 parent 72deb96
commit b87f4b2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/rude-peaches-scream.md b/.changeset/rude-peaches-scream.md
@@ -0,0 +1,8 @@
+---
+"@marko/language-tools": patch
+"@marko/language-server": patch
+"@marko/type-check": patch
+"marko-vscode": patch
+---
+
+Fix some flawed boolean logic
diff --git a/packages/language-tools/src/extractors/script/index.ts b/packages/language-tools/src/extractors/script/index.ts
@@ -710,11 +710,10 @@ constructor(_?: Return) {}
     const def = tagName ? this.#lookup.getTag(tagName) : undefined;
     const isHTML = def?.html;
     const importPath = !isHTML && resolveTagImport(this.#filename, def);
-    const isMissing = def && !isHTML && !importPath;
     let tagIdentifier: undefined | string;
     let isTemplate = false;
 
-    if (!isHTML || !isMissing) {
+    if (!isHTML && (!def || importPath)) {
       const tagId = this.#ensureTagId(tag);
       tagIdentifier = varLocal("tag_" + tagId);
       this.#extractor.write(`const ${tagIdentifier} = (\n`);