fix: use chunkFileNames default to avoid ssr assets in client folder

.changeset/chatty-boats-sparkle.md

@@ -0,0 +1,5 @@
+---
+"@marko/vite": patch
+---
+
+Switch to overriding the default chunkFileNames instead of assets dir to avoid server assets in client assets folder.

src/index.ts

@@ -242,16 +242,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
           runtimeId,
         });
 
-        if (isSSRBuild && !config.build?.ssrEmitAssets) {
-          config.build ??= {};
-
-          // For the server build vite will still output code split chunks to the `assets` directory by default.
-          // this is problematic since you might have server assets in your client assets folder.
-          // Here we change the default to be an empty string which makes the assetsDir essentially the same as
-          // as outDir for the server chunks.
-          config.build.assetsDir ??= "";
-        }
-
         if (isTest) {
           linked = false;
           const { test } = config as any;
@@ -311,6 +301,17 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
           }
         }
 
+        if (isSSRBuild && !config.build?.rollupOptions?.output) {
+          // For the server build vite will still output code split chunks to the `assets` directory by default.
+          // this is problematic since you might have server assets in your client assets folder.
+          // Here we change the default chunkFileNames config to instead output to the outDir directly.
+          config.build ??= {};
+          config.build.rollupOptions ??= {};
+          config.build.rollupOptions.output = {
+            chunkFileNames: `[name]-[hash].js`,
+          };
+        }
+
         if (basePathVar) {
           config.experimental ??= {};
 
@@ -324,19 +325,17 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
             config.build?.assetsDir?.replace(/[/\\]$/, "") ?? "assets";
           const assetsDirLen = assetsDir.length;
           const assetsDirEnd = assetsDirLen + 1;
-          const trimAssertsDir = assetsDir
-            ? (fileName: string) => {
-                if (fileName.startsWith(assetsDir)) {
-                  switch (fileName[assetsDirLen]) {
-                    case POSIX_SEP:
-                    case WINDOWS_SEP:
-                      return fileName.slice(assetsDirEnd);
-                  }
-                }
-
-                return fileName;
+          const trimAssertsDir = (fileName: string) => {
+            if (fileName.startsWith(assetsDir)) {
+              switch (fileName[assetsDirLen]) {
+                case POSIX_SEP:
+                case WINDOWS_SEP:
+                  return fileName.slice(assetsDirEnd);
               }
-            : (fileName: string) => fileName;
+            }
+
+            return fileName;
+          };
           config.experimental.renderBuiltUrl = (
             fileName,
             { hostType, ssr },