Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deleteXXX in addition to removeXXX #190

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Feb 11, 2025

Description

Make the integration with ra-graphql-data-simple simpler.
Support both removeXXX and deleteXXX to avoid breaking changes.

Related Issue

See marmelab/react-admin#4431

@djhi djhi added the RFR Ready For Review label Feb 11, 2025
@slax57 slax57 self-requested a review February 13, 2025 09:08
Copy link
Collaborator

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
But do we need to update the documentation?

@djhi djhi added WIP and removed RFR Ready For Review labels Feb 14, 2025
@djhi
Copy link
Contributor Author

djhi commented Feb 14, 2025

Support both removeXXX and deleteXXX to avoid breaking changes.

We don't document the dialect as you can explore it through graphiQL. Good enough for now

@slax57 slax57 added this to the 3.2.0 milestone Feb 14, 2025
@slax57 slax57 added RFR Ready For Review and removed WIP labels Feb 14, 2025
@slax57 slax57 merged commit 3dacec7 into master Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants