Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ra-data-localforage setup #10455

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 20, 2025

Problem

Setting up the ra-data-local-forage dataProvider is cumbersome.
You have to manage a state and initialize it in a useEffect.

Solution

Simplify the setup.

  • Implement the solution
  • Showcase it in a story

How To Test

In storybook

https://react-admin-storybook-git-ra-data-localforage-s-a105c6-marmelab.vercel.app/?path=/story/ra-data-local-forage--basic

In a new app

  • build the project
  • create a new react-admin app using the fakerest dataprovider
  • copy the ra-data-local-forage inside the new project node_modules
  • Setup the dataProvider instead of fakerest

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the WIP Work In Progress label Jan 20, 2025
@djhi djhi force-pushed the ra-data-localforage-simplify-setup branch from 66c9034 to beb5d9a Compare January 20, 2025 17:53
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Jan 20, 2025
@slax57 slax57 added this to the 5.5.1 milestone Jan 23, 2025
@slax57 slax57 merged commit 734c322 into master Jan 23, 2025
16 checks passed
@slax57 slax57 deleted the ra-data-localforage-simplify-setup branch January 23, 2025 13:40
@slax57 slax57 changed the title Simplify ra-data-local-forage setup Simplify ra-data-localforage setup Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants