Construct ClientRequest from &mut KeyConfig
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientRequests are single use so one making multiple requests needs to use they KeyConfig multiple times. Making each one from a reference rather than an owned `KeyConfig` allows this.
DanGould
force-pushed
the
ref-keyconfig
branch
from
3eeec8c to
7bc2aa2
Compare
|
Thanks Dan, this makes sense. Let me know if you would like me to cut a new release with this one. There are a few cleanup items to look into before I do that. |
|
It'd be great to get cut one but there's no pressure the way there was for KeyConfig to be Clone. I just had this change locally and figured I should upstream it. Thanks for the quick turnaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientRequests are single use so one making multiple requests needs to use the KeyConfig multiple times. Making each one from a reference rather than an owned
KeyConfigallows this.edit: The CI errors appear to be from the new clippy version and do not have to do with this change