Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added darktheme #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

skully-coder
Copy link

Added dark theme, and fixed some minor text related errors, and made text in the radio button description selectable

@skully-coder
Copy link
Author

Closes #9

@skully-coder
Copy link
Author

@masteradit can you review and merge this?

@masteradit
Copy link
Owner

Hey! I am sorry, got stuck in some work in the last few days. I checked out the code and have a few suggestions.

I think it would be easier to add this in ThemeData instead of manually specifying the colour of text everywhere:

darkTheme: ThemeData(
  primarySwatch: Colors.teal,
  brightness: Brightness.dark,
),
themeMode: themeVariable, // this variable can store ThemeMode.dark, ThemeMode.light or ThemeMode.system

Now, using setState, the value of themeVariable can be switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants