created classes and methods #2269
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request. The class name Exavator should be corrected to Excavator to prevent compilation errors. Additionally, the typo in the output string "stoped" should be corrected to "stopped" in the doWork() and stopWork() methods across the relevant classes. Once these issues are resolved, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| } | ||
|
|
||
| public void stopWork() { | ||
| System.out.println(carName + " is stoped..."); |
There was a problem hiding this comment.
There is a typo in the output string: 'stoped' should be corrected to 'stopped'.
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Exavator extends Machine { | |||
There was a problem hiding this comment.
There is a typo in the class name: 'Exavator' should be corrected to 'Excavator'.
| package core.basesyntax; | ||
|
|
||
| public class Exavator extends Machine { | ||
| private final String carName = "Exavator"; |
There was a problem hiding this comment.
There is a typo in the variable name: 'Exavator' should be corrected to 'Excavator' to match the corrected class name.
| } | ||
|
|
||
| public void stopWork() { | ||
| System.out.println(carName + " is stoped..."); |
There was a problem hiding this comment.
There is a typo in the output string: 'stoped' should be corrected to 'stopped'.
| Machine[] machines = new Machine[] { | ||
| new Truck(), | ||
| new Bulldozer(), | ||
| new Exavator(), |
There was a problem hiding this comment.
There is a typo in the class name: 'Exavator' should be corrected to 'Excavator' to match the corrected class name in the Excavator class definition.
| } | ||
|
|
||
| public void stopWork() { | ||
| System.out.println(carName + " is stoped..."); |
There was a problem hiding this comment.
There is a typo in the output string: 'stoped' should be corrected to 'stopped'.
There was a problem hiding this comment.
Great job on implementing the classes and methods as per the task requirements! 🎉 Your code effectively demonstrates polymorphism and adheres to the task constraints.
Here are a few points to consider for improvement:
-
Typo Correction: Ensure that the output string in the
stopWork()method of theBulldozerclass is corrected from "stoped" to "stopped" to maintain consistency across all classes. -
Attention to Detail: While the code meets the requirements, paying attention to minor details like typos can enhance the overall quality and readability of your code.
Your solution is approved to help you move forward with your learning journey. Please review the comments and make the necessary adjustments to improve your code. Keep up the good work and continue to learn from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| } | ||
|
|
||
| public void stopWork() { | ||
| System.out.println(carName + " is stopped..."); |
There was a problem hiding this comment.
The output string in the stopWork() method is correct here as 'stopped'. Ensure this consistency across all classes as per the task requirements.
No description provided.