Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do hommework #2272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

romander333
Copy link

No description provided.

@romander333 romander333 reopened this Jan 31, 2025
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Machine class hierarchy! 🎉 Your code meets the core requirements, and you've effectively used polymorphism in your MainApp class. Here are a few areas to improve:

  1. Informative Messages in Methods: Enhance the messages in doWork() and stopWork() methods to be more descriptive. For example, instead of "Truck doWork", use "Truck has started working".

  2. Access Modifiers: Explicitly declare access modifiers for your methods in the Machine class to adhere to best practices.

  3. Redundant Empty Lines: Remove unnecessary empty lines in your MainApp class for cleaner code.

These improvements will help you write more maintainable and readable code. Keep up the great work, and continue learning from each task! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants