Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved debug url check, #AS-292 #753

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Improved debug url check, #AS-292 #753

merged 2 commits into from
Feb 19, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Improved debug url check
Fixes: #AS-292

Review

snake14
snake14 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

snake14
snake14 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues 👍

@AltamashShaikh AltamashShaikh merged commit c65391e into 5.x-dev Feb 19, 2024
4 checks passed
@AltamashShaikh AltamashShaikh deleted the AS-292-improve-url-check-debug branch February 19, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review not-in-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AltamashShaikh @michalkleiner @snake14 @sgiehl