Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Analytics category is always shown at top, #PG-4052 #988

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Feb 18, 2025

Description:

Ensure Analytics category is always shown at top
Fixes: #PG-4052, #949

Review

snake14
snake14 previously approved these changes Feb 18, 2025
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and keeps the Analytics category at the top for Tags and Varibales, even when the language makes it not alphabetically first 👍

I just left one optional comment.

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making suggested changes. Everything looks good and works as expected 👍

@snake14 snake14 merged commit d8f386c into 5.x-dev Feb 19, 2025
5 checks passed
@snake14 snake14 deleted the PG-4052-pin-analytics-category branch February 19, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants