Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding window size check to analyze function #43

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frankiecancino
Copy link
Collaborator

  • Adding same window size check to analyze function
  • Added tests to assert the error returned from analyze

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #43 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   91.79%   91.80%   +0.01%     
==========================================
  Files          29       29              
  Lines        2205     2208       +3     
==========================================
+ Hits         2024     2027       +3     
  Misses        181      181              
Impacted Files Coverage Δ
matrixprofile/analyze.py 96.72% <75.00%> (+0.16%) ⬆️
matrixprofile/compute.py 92.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa68ae...42e3161. Read the comment docs.

@tylerwmarrs
Copy link
Contributor

@frankiecancino do you have some time to fix the merge conflicts?

@frankiecancino
Copy link
Collaborator Author

Yeah, this PR is a little outdated. I'll pull in the new changes and try to fix this code coverage. I was working on this one night then just lost track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants