Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-63351: Use latest URL #895

Merged
merged 2 commits into from
Mar 5, 2025
Merged

MM-63351: Use latest URL #895

merged 2 commits into from
Mar 5, 2025

Conversation

agarciamontoro
Copy link
Member

Summary

Now that https://mattermost.atlassian.net/browse/CLD-7570 is resolved, we have https://latest.mattermost.com/mattermost-load-test-ng-linux, which will always point to the latest release of the tool. This PR removes the hardcoded versions in the URLs in favour of this new URL, and removes the Makefile rule prepare-release, which is no longer needed.

Ticket Link

https://mattermost.atlassian.net/browse/MM-63351

This rule was used to update the version in the sample and test strings,
but now that we are using the latest URL, this is no longer needed.
@agarciamontoro
Copy link
Member Author

I'm cherry-picking to release-1.24 as soon as it's merged so that I can test the new, streamlined, release process with v1.24.1 🤓

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Once the simplification kicks in, what would be the best procedure to figure out which version of the tool is deployed? (e.g. I am debugging a failing comparison).

@agarciamontoro
Copy link
Member Author

what would be the best procedure to figure out which version of the tool is deployed

Oh, that's a good question. We don't currently have a straightforward way to know the version that's deployed, as far as I know. We could add a new /version endpoint that returns the SHA of the commit used to build the binary and add a new command to query it. And log it as well when the server starts.

I'm curious: How would you figure it out now, without the changes in this PR?

@streamer45
Copy link
Contributor

what would be the best procedure to figure out which version of the tool is deployed

Oh, that's a good question. We don't currently have a straightforward way to know the version that's deployed, as far as I know. We could add a new /version endpoint that returns the SHA of the commit used to build the binary and add a new command to query it. And log it as well when the server starts.

I'm curious: How would you figure it out now, without the changes in this PR?

I'd be looking at the deployer.json used :p I'd expect us to log which version gets downloaded at the very least.

@agarciamontoro
Copy link
Member Author

I'd be looking at the deployer.json used :p I'd expect us to log which version gets downloaded at the very least.

Yeah, we cannot even rely on the name in the agent machines (even now), since any reference to the original URL is gone. I just created a ticket for this, it shouldn't be too hard to write something that makes our lives easier.

@agarciamontoro agarciamontoro merged commit 701a1b4 into master Mar 5, 2025
1 check passed
@agarciamontoro agarciamontoro deleted the MM-63351.use.latest.url branch March 5, 2025 11:44
agarciamontoro added a commit that referenced this pull request Mar 5, 2025
* Use latest URL instead of hardcoded version

* Remove prepare-release rule, no longer needed

This rule was used to update the version in the sample and test strings,
but now that we are using the latest URL, this is no longer needed.
agarciamontoro added a commit that referenced this pull request Mar 6, 2025
* Use latest URL instead of hardcoded version

* Remove prepare-release rule, no longer needed

This rule was used to update the version in the sample and test strings,
but now that we are using the latest URL, this is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants