-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-63351: Use latest URL #895
Conversation
This rule was used to update the version in the sample and test strings, but now that we are using the latest URL, this is no longer needed.
I'm cherry-picking to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Once the simplification kicks in, what would be the best procedure to figure out which version of the tool is deployed? (e.g. I am debugging a failing comparison).
Oh, that's a good question. We don't currently have a straightforward way to know the version that's deployed, as far as I know. We could add a new I'm curious: How would you figure it out now, without the changes in this PR? |
I'd be looking at the |
Yeah, we cannot even rely on the name in the agent machines (even now), since any reference to the original URL is gone. I just created a ticket for this, it shouldn't be too hard to write something that makes our lives easier. |
* Use latest URL instead of hardcoded version * Remove prepare-release rule, no longer needed This rule was used to update the version in the sample and test strings, but now that we are using the latest URL, this is no longer needed.
Summary
Now that https://mattermost.atlassian.net/browse/CLD-7570 is resolved, we have https://latest.mattermost.com/mattermost-load-test-ng-linux, which will always point to the latest release of the tool. This PR removes the hardcoded versions in the URLs in favour of this new URL, and removes the Makefile rule
prepare-release
, which is no longer needed.Ticket Link
https://mattermost.atlassian.net/browse/MM-63351