Skip to content

Deps/django 52 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Deps/django 52 #572

wants to merge 14 commits into from

Conversation

Floris272
Copy link
Contributor

@Floris272 Floris272 commented Apr 22, 2025

Fixes #568 #566

Changes

  • Updates django to 5.2
  • Updates django-webtest to 1.9.13
  • Enables connection pooling
    • adds pool options as env vars
  • adds CONN_MAX_AGE setting
  • Changes ObjectRecordInline to use GeoModelAdminMixin
  • Changes logout admin link to button
  • Adds ci job to test pooling & conn_max_age (separately)

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (4a93312) to head (0aae809).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +0.01%     
==========================================
  Files         147      147              
  Lines        5103     5113      +10     
==========================================
+ Hits         4830     4840      +10     
  Misses        273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Floris272 Floris272 marked this pull request as ready for review April 24, 2025 11:45
Copy link
Contributor

@danielmursa-dev danielmursa-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

@Floris272 Floris272 force-pushed the deps/django-52 branch 2 times, most recently from 8eeb923 to 1a1a1e0 Compare April 25, 2025 10:02
@Floris272
Copy link
Contributor Author

@stevenbal I'm not sure about the ci job, maybe it should be a performance test? but i'm also fine with removing it.

@Floris272 Floris272 requested a review from stevenbal April 28, 2025 09:27
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the connection pooling locally and seems to work as expected 👍

@stevenbal stevenbal self-requested a review May 1, 2025 14:15
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to rebase on master to fix the merge conflicts

@Floris272 Floris272 requested a review from stevenbal May 2, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Objects API to Django 5.2 and allow setting of connection pooling
4 participants