-
Notifications
You must be signed in to change notification settings - Fork 14
Deps/django 52 #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Deps/django 52 #572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 94.65% 94.66% +0.01%
==========================================
Files 147 147
Lines 5103 5113 +10
==========================================
+ Hits 4830 4840 +10
Misses 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
21ea250
to
ee2d422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me!
8eeb923
to
1a1a1e0
Compare
@stevenbal I'm not sure about the ci job, maybe it should be a performance test? but i'm also fine with removing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the connection pooling locally and seems to work as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to rebase on master to fix the merge conflicts
Fixes #568 #566
Changes