-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Custom Output Format" #123
Conversation
@kw4tts thanks for this! regarding ^1: seems reasonable? I'd like to merge it after you un-draft it 👍 |
@mbolli thanks for your opinion and approval 👍 Will keep this draft as long as we're testing this (hopefully I get to have some more feedback from our team) and will reach out in a week or so. |
Our team suggested that, with the ability to utilize COF, one might not necessarily want to (always) hide some of the columns, especially if they are in the COF itself. By default, this is a thing, and is done in nfsen-ng.js L1085 +- context. I have a rough idea on how to fix that, with defaults being a noop change for most of the people, so I will hopefully implement that during this week and push in this PR as it's COF-related, if you don't mind. |
makes sense! |
Being open for further discussion: On flow submit request:
Seems OK for me right now, but will test that out tomorrow with the team. If you have an option to give it a spin, happy to find out feedback. |
@mbolli We're running this in our environment now. You are more than welcome to have another glance over it. Unless you have anything else to recommend/suggest, I consider this to be ready to be merged. I do have some UI "fixes", but that's just us, can be taken as a suggestion, and is therefore put aside in another branch. Happy holidays! |
@kw4tts I hope you enjoyed the holidays. Thanks again for this. LGTM. |
This is a fast implementation of feature, requested / noted to be missing in #122 :
loads Custom Output Formats (COF) from nfsen-ng config file (^1)
Allows user to add COF
(-> drop-down:"custom", fill out field, click "add new")
Allows user to add COF based on pre-selecting and modifying existing one
(-> drop-down: custom filter, modify in input field, click "add new")
Allows user to edit existing COF (^1)
(-> drop-down: custom filter, modify in input field, click "modify/delete")
Allows user to delete existing saved COF.
(-> drop-down: custom filter, erase the input field, click "modify/delete", confirm)
Comments welcome. As said, this is a quickly written implementation, there might be room for improvement.
Regards,
E/kw4tts
^1: Rules, saved on server, will overwrite users' preferences each time the page loads. What is your opinion on that?