-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-1930334 to implement background.preferred_environment #37876
base: main
Are you sure you want to change the base?
Bug-1930334 to implement background.preferred_environment #37876
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
Preview URLs
Flaws (2)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2025-01-31 16:10:19) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs! Made a few changes to clarify this is an array, not a string value.
<tr> | ||
<td><code>preferred_environment</code></td> | ||
<td> | ||
<p>A <code>String</code> value.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>A <code>String</code> value.</p> | |
<p>An <code>Array</code> of <code>String<code>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosjeurissen so you could specify ["document", "service_worker"]
? Or can you only specify one value in the array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebloor yes, multiple values can be specified. Any of the following are valid:
["document", "service_worker"]
["service_worker", "document"]
["service_worker"]
["document"]
And potentially more
The most sensible at this moment however are
["service_worker", "document"]
and
["document", "service_worker"]
As you either prefer the "document" or "service_worker" environment.
files/en-us/mozilla/add-ons/webextensions/manifest.json/background/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/background/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: carlosjeurissen <1038267+carlosjeurissen@users.noreply.github.com>
Description
Add release note and documentation for the introduction of
preferred_environment
to thebackground
manifest key as implemented by Bug 1930334 Implement background.preferred_environment.Related issues and pull requests
Corresponding changes to the browser compatibility data in TBC