Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature list for CSS Paged Media module #37883

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

Description

Motivation

Additional details

https://drafts.csswg.org/css-page/

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 30, 2025 15:16
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 30, 2025 15:16
@skyclouds2001 skyclouds2001 requested review from chrisdavidmills and removed request for a team January 30, 2025 15:16
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview URLs

(comment last updated: 2025-02-06 15:23:01)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skyclouds2001, and thanks again for your MDN contributions!

I have a few comments here. Let me know what you think.

files/en-us/web/css/css_paged_media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_paged_media/index.md Show resolved Hide resolved
files/en-us/web/css/css_paged_media/index.md Show resolved Hide resolved
@Josh-Cena
Copy link
Member

I slightly prefer the originally form with the fragmentation properties in "See also", but I'm not familiar with CSS norms so I'll defer to others.

@skyclouds2001 skyclouds2001 requested a review from estelle February 6, 2025 15:22
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants