Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vehicle Profile] Jaguar I-PACE #219

Merged
merged 18 commits into from
Oct 9, 2024
Merged

[Vehicle Profile] Jaguar I-PACE #219

merged 18 commits into from
Oct 9, 2024

Conversation

seanauff
Copy link
Contributor

@seanauff seanauff commented Oct 1, 2024

Confirmed working on my model year 2019. Based on the work of @dernotte for OVMS3. Currently only the BECM PIDs (except VIN) are supported. More info in the README

@seanauff seanauff requested a review from meatpiHQ as a code owner October 1, 2024 22:31
@dernotte
Copy link

dernotte commented Oct 2, 2024

There is a good reading here about latest finding on Ipace canbus... https://www.i-paceforum.com/threads/hv-battery-reports-autel-scanner-tool-can-do-it.8773/#replies

@seanauff
Copy link
Contributor Author

seanauff commented Oct 2, 2024

There is a good reading here about latest finding on Ipace canbus... https://www.i-paceforum.com/threads/hv-battery-reports-autel-scanner-tool-can-do-it.8773/#replies

Great stuff! I had been following that thread a month ago, good to see some progress. I'll try and replicate.

Copy link
Owner

@meatpiHQ meatpiHQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!

Please change the expression (B4*256)+B5 to [B4:B5]

@seanauff
Copy link
Contributor Author

seanauff commented Oct 3, 2024

Can do! For odometer I have B4*65536+B5*256+B6. How should that be formatted? [B4:B6]? My Google fu is not leading me to a reference for the colon operator

@meatpiHQ
Copy link
Owner

meatpiHQ commented Oct 6, 2024

Can do! For odometer I have B4*65536+B5*256+B6. How should that be formatted? [B4:B6]? My Google fu is not leading me to a reference for the colon operator

Yes that's right, it should be [B4:B6].

@seanauff
Copy link
Contributor Author

seanauff commented Oct 6, 2024

OK, all set!

@meatpiHQ
Copy link
Owner

meatpiHQ commented Oct 8, 2024

@seanauff one more thing, please remove vehicle_profiles.json from the PR. This file will be automatically generated.

@meatpiHQ meatpiHQ merged commit ea90775 into meatpiHQ:main Oct 9, 2024
1 check passed
@seanauff
Copy link
Contributor Author

seanauff commented Oct 9, 2024

Thanks! I've disabled that action on my fork so future PRs won't have that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants