Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of standard params.
The idea is we define a list of params we have and want to use, then different profiles use those params. This removes lots of the duplication from profiles, e.g. SOC will always be a battery % between 0 and 100, no need to repeat that over and over. This also allows us to start to know for sure what different paramaters are, e.g. the HA integration can provide a translation for SOC to
State Of Charge
in mutliple languages, something that we need standard params to doThis generates identical
vehicle_profiles.json
as the end result, no need for FW/processing changes, thats all dealt with in the generation of the final json file.ATM this test is limited to just the bmw profile, to merge would need to un-limit it from only BMW, as well as update all existing profiles.
TODO
params.json