New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/empty ref bins #197

Merged

nlouwen merged 2 commits into dev from hotfix/empty-ref-bins

Oct 23, 2024

Collaborator

nlouwen commented Oct 22, 2024

Changes the logic of cull_singletons to prevent creating 'empty' output folders for ref only bins:

No longer relies on distance table, instead on connected component table.
No longer distinguishes between ref_only singletons, as this is already done during connected component generation.
As an added bonus, now correctly culls ref only connected components from the final bin

adds the full used command to the logs

nlouwen added 2 commits

October 22, 2024 15:20


          prevent output folder creation for ref only bins

ecdd3e7


          include full command in log file

4201df4

nlouwen requested a review from CatarinaCarolina

October 22, 2024 13:28

CatarinaCarolina approved these changes

View reviewed changes

Collaborator

CatarinaCarolina left a comment

lgtm

nlouwen merged commit 1210a0a into dev

4 checks passed

nlouwen deleted the hotfix/empty-ref-bins branch

October 23, 2024 07:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet