Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/27 summary only once #29

Merged
merged 11 commits into from
Jul 5, 2024
Merged

Issues/27 summary only once #29

merged 11 commits into from
Jul 5, 2024

Conversation

wetret
Copy link
Member

@wetret wetret commented Jul 2, 2024

resolves #27

@wetret wetret added this to the v1.1.0.1 milestone Jul 2, 2024
@wetret wetret self-assigned this Jul 2, 2024
@wetret wetret requested review from schwzr, juliangruendner and alexanderkiel and removed request for schwzr July 2, 2024 14:39
alexanderkiel
alexanderkiel requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@alexanderkiel alexanderkiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only critical comment is that with the URL encoding. All others are optional remarks.

src/main/java/de/medizininformatik_initiative/process/report/service/CheckSearchBundle.java Outdated Show resolved Hide resolved
src/test/resources/fhir/Bundle/search-bundle-invalid-date-filter.xml Show resolved Hide resolved
src/test/resources/fhir/Bundle/search-bundle-invalid-date-filter.xml Show resolved Hide resolved
src/test/resources/fhir/Bundle/search-bundle-invalid-date-filter.xml Show resolved Hide resolved
src/test/resources/fhir/Bundle/search-bundle-invalid-summary-double.xml Show resolved Hide resolved
...st/java/de/medizininformatik_initiative/process/report/bpe/CheckSearchBundleServiceTest.java Show resolved Hide resolved
@juliangruendner

This comment was marked as resolved.

Sign in to view
@juliangruendner

This comment was marked as resolved.

Sign in to view
@juliangruendner

This comment was marked as resolved.

Sign in to view
@alexanderkiel

This comment was marked as resolved.

Sign in to view
@juliangruendner

This comment was marked as resolved.

Sign in to view
@wetret

This comment was marked as resolved.

Sign in to view
@wetret wetret requested a review from alexanderkiel July 3, 2024 13:40
@wetret wetret requested a review from juliangruendner July 3, 2024 14:14
@wetret wetret requested a review from alexanderkiel July 5, 2024 06:59
@wetret wetret merged commit 9e6036d into develop Jul 5, 2024
1 check passed
@wetret wetret linked an issue Jul 5, 2024 that may be closed by this pull request
Ensure _summary parameter only appears exactly once #27
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruendner juliangruendner juliangruendner approved these changes

@schwzr schwzr schwzr approved these changes

@alexanderkiel alexanderkiel alexanderkiel approved these changes

Assignees

@wetret wetret

Labels
None yet
Projects
None yet
Milestone
v1.1.0.1
Development

Successfully merging this pull request may close these issues.

Ensure _summary parameter only appears exactly once
4 participants
@wetret @juliangruendner @alexanderkiel @schwzr