fix: cyclopedia item filters & market voc filter

[bdzicc]

Description

The cyclopedia filters have a few issues:

1. Selecting any of the item filters clears out all items. This is simply due to a scoping error which is easily fixed.

2. Fixing the scoping error then revealed that there is an issue with displaying items based on the vocation filter.
   The vocations are as follows:
   1 = knight
   2 = paladin
   3 = sorcerer
   4 = druid

When restrictVocation bitmask is calculated on the C++ side and an item is for a knight and paladin the value is 3 which is the same as sorcerer. As a result, sorcerers are seeing items for knights and paladins. Also, with the current logic for the filter each vocation is only seeing items that are explicitly for their vocation and none of the items with multiple vocations nor items with no vocation req.

I have changed the restrictVocation bitmask to the following:
1 = knight
2 = paladin
4 = sorcerer
8 = druid

This way each bit represents each vocation and no overlap can occur when combining.

These changes also fix the vocation filtering for the market items as well.

Behavior

Actual

Selecting an items filter clears all results
Selecting vocation filter shows incorrect results

Expected

Selecting filters should show correct items based on player level/voc

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• Selected level/voc items filters for each vocation and ensured correct items were displayed

Test Configuration:

• Server Version:Canary 13.40
• Client: OTC Mehah
• Operating System: Windows 10

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud