-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): Add pytest-github-actions-annotate-failures
for GitHub workflows of tap, target and mapper templates
#2872
Conversation
Reviewer's Guide by SourceryThis pull request adds the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
8012f89
to
fab41f1
Compare
…tHub workflows of tap, target and mapper templates
fab41f1
to
ffef3c6
Compare
…-for-userwarnings-and-possibly-other-cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to explain why
tox>=4.22
is required. - It might be worth extracting the conditional
pytest-github-actions-annotate-failures
dependency into a separate group to avoid repetition.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Adds
pytest-github-actions-annotate-failures
to the test dependencies of tap, target, and mapper templates, and updates the minimum required version oftox
.New Features:
pytest-github-actions-annotate-failures
to the test dependencies of tap, target, and mapper templates, enabling automatic annotation of test failures in GitHub Actions workflows.Enhancements:
tox
to 4.22 in tap, target and mapper templates.test
dependency group todev
dependency group in tap, target and mapper templates.📚 Documentation preview 📚: https://meltano-sdk--2872.org.readthedocs.build/en/2872/