-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: Pinned docs dependencies and use PEP 735 for them #2883
Conversation
Reviewer's Guide by SourceryThis pull request migrates the documentation dependencies to a dedicated dependency group, manages them using PEP 735, and adds a uv badge to the README. Flow diagram for documentation build processgraph LR
A[Update pyproject.toml with docs dependencies] --> B{Run pre-commit hook: uv-export}
B -- Generates --> C[docs/requirements.txt]
C --> D[Readthedocs build process]
D -- Installs dependencies from --> C
D --> E[Documentation is built]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the
docs
dependencies were moved fromproject.optional-dependencies
todependency-groups
. - It might be helpful to add a short description of what PEP 735 is in the commit message.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CodSpeed Performance ReportMerging #2883 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 62 62
Lines 5203 5203
Branches 675 675
=======================================
Hits 4752 4752
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
This pull request updates the documentation build process to use a
requirements.txt
file for installing dependencies, generated from thedocs
dependency group inpyproject.toml
. This change leverages PEP 735 for improved dependency management and ensures consistent documentation builds across different environments.Build:
docs
dependency group inpyproject.toml
, leveraging PEP 735 for improved dependency management.CI:
requirements.txt
file, ensuring consistent dependency installation for documentation builds.Documentation:
requirements.txt
file to install documentation dependencies, ensuring consistent and reproducible documentation builds.Chores:
uv.lock
file and update.gitignore
to exclude it, asuv
is no longer directly managing the dependencies.📚 Documentation preview 📚: https://meltano-sdk--2883.org.readthedocs.build/en/2883/