Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Update tap, target and mapper dependencies in templates #2885

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 25, 2025

Summary by Sourcery

Updates the dependencies in the tap, target, and mapper templates, specifically pre-commit hooks and mypy configuration.

Enhancements:

  • Update pre-commit hooks in tap, target, and mapper templates to use the latest versions of check-jsonschema, ruff-pre-commit, mirrors-mypy, and uv-pre-commit.
  • Remove python_version = "3.12" from mypy configuration in tap, target, and mapper templates.

Chores:

  • Update dependencies in tap, target and mapper templates.

📚 Documentation preview 📚: https://meltano-sdk--2885.org.readthedocs.build/en/2885/

Copy link
Contributor

sourcery-ai bot commented Feb 25, 2025

Reviewer's Guide by Sourcery

This pull request updates the tap, target, and mapper templates to use the latest versions of pre-commit hooks and removes the python_version from mypy configuration. The pre-commit hooks check-jsonschema, ruff-pre-commit, mirrors-mypy, and uv-pre-commit were updated to their latest versions. The python_version setting was removed from the mypy configuration in all three templates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated pre-commit hook versions for check-jsonschema, ruff-pre-commit, mirrors-mypy, and uv-pre-commit.
  • Updated check-jsonschema from version 0.31.0 to 0.31.2.
  • Updated ruff-pre-commit from version v0.9.3 to v0.9.7.
  • Updated mirrors-mypy from version v1.14.1 to v1.15.0.
  • Updated uv-pre-commit from version 0.5.26 to 0.6.3.
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/.pre-commit-config.yaml
cookiecutter/tap-template/{{cookiecutter.tap_id}}/.pre-commit-config.yaml
cookiecutter/target-template/{{cookiecutter.target_id}}/.pre-commit-config.yaml
Removed python_version from mypy configuration.
  • Removed the python_version setting from the [tool.mypy] section.
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml
cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@edgarrmondragon edgarrmondragon self-assigned this Feb 25, 2025
@edgarrmondragon edgarrmondragon added this to the v0.45 milestone Feb 25, 2025
@edgarrmondragon edgarrmondragon added Dependencies Cookiecutter Tap, target and mapper templates labels Feb 25, 2025
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 25, 2025 17:56
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner February 25, 2025 17:56
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edgarrmondragon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cookiecutter Tap, target and mapper templates Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant