-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): Update tap, target and mapper dependencies in templates #2885
base: main
Are you sure you want to change the base?
feat(templates): Update tap, target and mapper dependencies in templates #2885
Conversation
Reviewer's Guide by SourceryThis pull request updates the tap, target, and mapper templates to use the latest versions of pre-commit hooks and removes the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Updates the dependencies in the tap, target, and mapper templates, specifically pre-commit hooks and mypy configuration.
Enhancements:
check-jsonschema
,ruff-pre-commit
,mirrors-mypy
, anduv-pre-commit
.python_version = "3.12"
from mypy configuration in tap, target, and mapper templates.Chores:
📚 Documentation preview 📚: https://meltano-sdk--2885.org.readthedocs.build/en/2885/