feat: publish multi arch docker image to dockerhub #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker workflow has been updated to use Buildpacks for building and pushing the Docker image. This change improves the build process and ensures compatibility with the latest versions of the required dependencies.
Ch4s3r
changed the title
|
@jusx @shine2lay could any of you please have a look when you have time ? :) |
shine2lay
approved these changes
Jun 10, 2024
|
@Ch4s3r I checked that we have DOCKERHUB_TOKEN in repository secrets |
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new release tag is created, trigger a new docker image build, using the provided
Dockerfile.Builds an image for
arm64,amd64andarm/v7on parallel running runners with different architecture, for native compilation speed.Combines all images into one multi arch build and uploads it to dockerhub as
mergeability/mergeable.This image is then tagged with the version from the github tag and the
latesttag.Can also be triggered manually which then only creates the
latesttag.Most of the code comes from the official docker docs on how to build a multi arch image.
Fixes #597
Tested and verified it works when pushing a release tag.
Todos:
secrets.DOCKERHUB_PASSWORDtosecrets.DOCKERHUB_TOKEN(not sure if password is still accepted by dockerhub)