-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDL3 wrap. #1919
base: master
Are you sure you want to change the base?
Add SDL3 wrap. #1919
Conversation
86c6d90
to
00f2af8
Compare
foreach f : check_functions | ||
if cc.has_function(f.get(1), prefix : f.get(2), dependencies: [sdl_deps]) | ||
cdata.set(f.get(0), 1) | ||
endif | ||
endforeach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early Windows failure since dl can be a Windows emulated one which we happen to provide in the wrapdb -- and thus has_function fails as it's forbidden to try to check an un-built subproject.
I suppose that isn't a general problem outside of the wrapdb CI... if https://github.com/dlfcn-win32/dlfcn-win32 isn't useful for SDL3 we can just use allow_fallback: false
for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work. I did not touch it at all, so 🤷 .
fd6c62b
to
c4071a5
Compare
Can you also create wrap for SDL_image SDL_shadercross libs? |
Maybe, but this would need to be done first. For example I have not actually tested if this actually works as I don't have any SDL3 test code around. So if someone could try this and post their results here, it would be helpful. |
Note that this is currently broken. It only does Linux. There is no configuration. It builds and links. It might work. I don't know as I did not test. Do not merge until it has at least Windows and macOS support.