MBS-13925: Instrument name erroneously displayed in link type autocomplete #3467
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plete This was due to `_getRequiredAttributes` inappropriately caching its result when `attributesByRootName` was specified. Results should only be cached when root attributes are being returned. I've removed the `attributesByRootName` argument altogether and now just merge the relationship-specific attribute names within `getPhraseAndExtraAttributes` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MBS-13925
This was due to
_getRequiredAttributesinappropriately caching its result whenattributesByRootNamewas specified. Results should only be cached when root attributes are being returned.Solution
I've removed the
attributesByRootNameargument altogether and now just merge the relationship-specific attribute names withingetPhraseAndExtraAttributesinstead.Testing
Manual testing + unit tests added in root/static/scripts/edit/utility/linkPhrase.js.