Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the logic that determines previous git tag #2045

Closed

Conversation

huutomerkki
Copy link
Member

What this PR does / why we need it:

This PR changes the way previous tag is determined to only include those tags that have been merged into the current tree.

Signed-off-by: Minna Färm <minna.farm@est.tech>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the right change, but practically not working. For example, we don't have v0.6.0 tag in main at all, nor we have v0.8.0, so if we check what the command now picks for v0.9.0, it'll compare it to v0.5.0.

Issue here is that when we make minor RC releases, they're already made from release branches. Thus the tags do not appear in main, and are not considered when making next minor. In release branches this logic works, but so does the old one.

@tuminoid
Copy link
Member

tuminoid commented Nov 8, 2024

Also, metal3-io/ip-address-manager#734 in IPAM will change the release creation logic, and will implement the same in Go code, so it makes no sense to implement this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants