Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Add v1.7.4 release note #818

Merged
merged 1 commit into from
Dec 23, 2024
Merged

🚀 Add v1.7.4 release note #818

merged 1 commit into from
Dec 23, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 20, 2024

Adding v1.7.4 release note

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-v1.7.4-release-note branch from 713b512 to 408b108 Compare December 20, 2024 11:34
tuminoid
tuminoid reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

We have one round of tags done already, let's not mess it up by redoing it via another workflow.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-v1.7.4-release-note branch from 408b108 to ba2a13a Compare December 20, 2024 11:39
tuminoid
tuminoid reviewed Dec 20, 2024
View reviewed changes
config/default/manager_image_patch.yaml Outdated
@@ -8,5 +8,5 @@ spec:
spec:
containers:
# Change the value of image field below to your controller image URL
- image: quay.io/metal3-io/ip-address-manager:main
- image: quay.io/metal3-io/ip-address-manager:v1.7.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is on main, can't change this.

releasenotes/v1.7.4.md Outdated
@@ -0,0 +1,13 @@
<!-- markdownlint-disable no-inline-html line-length -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line is not from the generator, remove it.

@mquhuy
Add v1.7.4 release note
ee19939 
Adding v1.7.4 release note

Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/add-v1.7.4-release-note branch from ba2a13a to ee19939 Compare December 20, 2024 12:00
tuminoid
tuminoid reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/cc @adilGhaffarDev

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@metal3-io-bot metal3-io-bot merged commit 9cfe847 into metal3-io:main Dec 23, 2024
11 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-v1.7.4-release-note branch December 23, 2024 06:32
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
IPAM - v1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @tuminoid @adilGhaffarDev