✨ Allow independent credentials for JSON RPC #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtantsur
force-pushed
the
json-rpc-cred
branch
2 times, most recently
from
6fbe31a to
ed7f8c5
Compare
metal3-io-bot
added
the
size/M
|
/test metal3-ubuntu-e2e-integration-test-main |
metal3-io-bot
added
the
needs-rebase
dtantsur
force-pushed
the
json-rpc-cred
branch
from
e1f3075 to
a427363
Compare
metal3-io-bot
removed
the
needs-rebase
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
metal3-io-bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
metal3-io-bot
removed
the
lifecycle/stale
It's probably not a great idea to allow users to easily access JSON RPC, so a different set of credentials is useful. Also allow the secret to be mounted directly without the convoluted auth-config format (which is an ini file in reality). Deprecate the auth-config approach (JSON RPC is the last instance where it's used). Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
json-rpc-cred
branch
from
a427363 to
7978e68
Compare
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
tuminoid
reviewed
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably not a great idea to allow users to easily access JSON RPC,
so a different set of credentials is useful.
Also allow the secret to be mounted directly without the convoluted
auth-config format (which is an ini file in reality). Deprecate
the auth-config approach (JSON RPC is the last instance where it's
used).