Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: add frr-k8s-external deployment entry #500

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

oribon
Copy link
Member

@oribon oribon commented Jan 22, 2025

We add an entry for frr-k8s-external bgp mode,
which should be ran with the namespace where frr-k8s is already deployed. We skip it in CI until we put a
setup that deploys frr-k8s before running the tests.

Is this a BUG FIX or a FEATURE ?:

/kind cleanup

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

We add an entry for frr-k8s-external bgp mode,
which should be ran with the namespace where frr-k8s is
already deployed. We skip it in CI until we put a
setup that deploys frr-k8s before running the tests.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@oribon oribon force-pushed the e2e_frr-k8s_external branch from 2066be0 to 94df325 Compare January 22, 2025 12:19
@fedepaol
Copy link
Member

LGTM

@fedepaol fedepaol added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2025
@oribon oribon added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 23, 2025
@oribon oribon added this pull request to the merge queue Jan 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 26, 2025
@oribon oribon merged commit 41c99ee into metallb:main Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants