Add attribute manipulation to the CME #867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve conflicts in dia-controller and dia-api
Resolve conflicts in dia-controller and add-class-to-vis
…ock-fix Try to resolve by building on top of lock from main
Deploying dataspecer with
|
| Latest commit: |
805f43e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca0fb8d6.dataspecer.pages.dev |
| Branch Preview URL: | https://cme-feature-attribute-manipu-7tnq.dataspecer.pages.dev |
This was
linked to
issues
Jan 22, 2025
This was
linked to
issues
Jan 22, 2025
skodapetr
reviewed
Feb 5, 2025
applications/conceptual-model-editor/src/action/actions-react-binding.tsx
Show resolved
Hide resolved
applications/conceptual-model-editor/src/action/add-semantic-attribute-to-visual-model.ts
Outdated
Show resolved
Hide resolved
applications/conceptual-model-editor/src/action/add-semantic-attribute-to-visual-model.ts
Show resolved
Hide resolved
applications/conceptual-model-editor/src/action/open-add-attribute-for-entity-dialog.ts
Show resolved
Hide resolved
applications/conceptual-model-editor/src/action/open-create-class-dialog-with-derived-model.tsx
Outdated
Show resolved
Hide resolved
| moveToNewPosition: ( | ||
| sourceFieldInState: keyof EditNodeAttributesState, | ||
| targetFieldInState: keyof EditNodeAttributesState, | ||
| oldPosition: number, |
There was a problem hiding this comment.
This can use a comment.
Again, interface, API --> comments.
There was a problem hiding this comment.
Commented, at least here (+ improved the API).
As for the rest I will try to document as I go and document the remainders later in the cleaning up PR.
applications/conceptual-model-editor/src/dialog/class/edit-node-attributes-dialog.tsx
Outdated
Show resolved
Hide resolved
applications/conceptual-model-editor/src/dialog/class/edit-node-attributes-dialog.tsx
Outdated
Show resolved
Hide resolved
applications/conceptual-model-editor/src/dialog/class/edit-node-attributes-dialog.tsx
Outdated
Show resolved
Hide resolved
| {...provided.draggableProps} | ||
| {...provided.dragHandleProps} | ||
| className="relative flex w-full flex-row justify-between z-50" | ||
| style={{ |
There was a problem hiding this comment.
Some of those, perhaps all, have their version in Tailwind.
Use of Tailwind classes is preffered to CSS style.
There was a problem hiding this comment.
Rewritten using tailwind, I don't remember but I mostly use either tailwind. And .css files for the diagram entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
contentofVisualNodes, that meanscontentarray)