Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MemberSlot
MemberSlot
extendsSlot
and is designed to update references to member functions as they move or are copied.e.g.
Now, when
emit
is called,render()
will be called on each instance ofPopup
What has happened is that during the copy of
MemberSlot
, the callback function ofshow
is recreated with a different value forthis
.Calculating the value of
this
relies on the offset in bytes between the twoMemberSlot
instances being the same as the offset between the twoPopup
instances.