treewide: group import statements std, external, crate #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a check to validate that? It will probably break again otherwise. |
KarlK90
force-pushed
the
chore/fmt-import-groups
branch
from
d5cad5e to
9ecd755
Compare
group_imports requires a nightly toolchain, running cargo fmt without the nightly channel prints a warning but doesn't fail the formatting. [1]: https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=import#group_imports Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
KarlK90
force-pushed
the
chore/fmt-import-groups
branch
2 times, most recently
from
3a8025d to
eeed91a
Compare
group_imports fmt rule requires the nightly toolchain, thus install and run the fmt check step with this toolchain. Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
This was done using the unstable rustfmt option[1] group_imports that requires a nightly toolchain, thus it was run manually. [1]: https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=import#group_imports Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
KarlK90
force-pushed
the
chore/fmt-import-groups
branch
from
eeed91a to
6dd5af3
Compare
|
I have added the nightly toolchain to the format check - note that the rustfmt option wasn't stabilized yet as there have been edge cases. We might have to disable it in the future if we run into regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done using the unstable rustfmt option1 group_imports that requires a nightly toolchain, thus it was run manually.