feat: raise any httpx exceptions, e.g. from failed auth #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
feat/raise-httpx-exceptions
branch
11 times, most recently
from
46e132d to
51fdee2
Compare
This means that 403s, such as those from not being allowed to fetch a specific version, are passed to client code, and so help debug permission errors better than the disk i/o error that's being raised right now. It also means there is consistency - before this change if there's a 403 (or any other connection error) from the initial HEAD request on the start of a query, then that was being passed to client now. Now, during the read data during the query if these get raised they get passed to client code. A few more tests have been added that seem maybe unreleated, but they test code paths of when there are not any httpx exception, but there are SQLite exceptions.
michalc
force-pushed
the
feat/raise-httpx-exceptions
branch
from
51fdee2 to
0a836ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that 403s, such as those from not being allowed to fetch a specific version, are passed to client code, and so help debug permission errors better than the disk i/o error that's being raised right now.
It also means there is consistency - before this change if there's a 403 (or any other connection error) from the initial HEAD request on the start of a query, then that was being passed to client now. Now, during the read data during the query if these get raised they get passed to client code.
A few more tests have been added that seem maybe unreleated, but they test code paths of when there are not any httpx exception, but there are SQLite exceptions.