make only streams that aren't already playing selectable in StreamsModal #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
This PR makes modifies the StreamsModal, which is what launches when you attempt to start a new stream. It filters out all already-playing streams from the selection dialog. This is a bit of an inverted way to close #501 , but is possibly a bit more intuitive and helps avoid messy logic around keeping streams running on the same source with zero interruption and just adding zones to the source, which is what the ticket details. Instead, we shift left and make the user do this if this is their intention.
In the non-webapp context, one can still steal streams; that's explicitly supported functionality and lives within the
ctrl.py
code.I'm pretty sure the
input
field is always either'None'
or starts withstream=
, but that's one way this is brittle, for sure.Checklist
./scripts/test