Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make only streams that aren't already playing selectable in StreamsModal #770

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

rtertiaer
Copy link
Contributor

What does this change intend to accomplish?

This PR makes modifies the StreamsModal, which is what launches when you attempt to start a new stream. It filters out all already-playing streams from the selection dialog. This is a bit of an inverted way to close #501 , but is possibly a bit more intuitive and helps avoid messy logic around keeping streams running on the same source with zero interruption and just adding zones to the source, which is what the ticket details. Instead, we shift left and make the user do this if this is their intention.

In the non-webapp context, one can still steal streams; that's explicitly supported functionality and lives within the ctrl.py code.

I'm pretty sure the input field is always either 'None' or starts with stream=, but that's one way this is brittle, for sure.

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If applicable, have you updated the CHANGELOG?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms? Firefox & Chromium
  • If this is a UI change, have you tested across multiple viewport sizes (ie. desktop versus mobile)?

@rtertiaer rtertiaer requested a review from SteveMicroNova June 24, 2024 20:44
@rtertiaer rtertiaer marked this pull request as ready for review June 24, 2024 20:45
Copy link
Contributor

@SteveMicroNova SteveMicroNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love quick and easy ways of solving issues. Props to bringing this up in the meeting as an "Is this intended or no?" situation, only removing the issue from the frontend and leaving it as a feature in the backend

@rtertiaer rtertiaer merged commit 003e894 into main Jun 25, 2024
3 checks passed
@rtertiaer rtertiaer deleted the no_steal_streams branch June 25, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a check for if a stream is already being played before it can be added to another source
2 participants