Message Extension Search Sample Fixes #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mohammed-MSFT We appear to have duplicated some work. Lets go with your PR, but can you reconcile yours with mine: #52. The error with selecting a package I found was with a description containing newlines, which caused JSON errors. |
@Mohammed-MSFT ? |
tracyboehrer
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Below Issue in one pr Please review and approve
Issue 1 : MessagingExtensionSearch sample README images no longer correct
Issue 2 :[Team's Messaging Extension search sample] Unexpected results when selecting a package without an icon
Issue 3: [Team's Messaging Extension search sample] Unexpected results when searching for any package