Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for the Microsoft.Agents.BotBuilder.Dialogs namespace #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add unit tests for the Microsoft.Agents.BotBuilder.Dialogs namespace #91

wants to merge 2 commits into from

Conversation

sw-joelmut
Copy link
Collaborator

Description

This PR creates unit tests to cover the classes in Microsoft.Agents.BotBuilder.Dialogs, increasing the code coverage up to 91%.

Detailed Changes

  • Fixed Recognizer issue when assigning properties to a JsonObject.
  • Fixed an issue when serializing a Dictionary, it generates an empty object without a property. eg {"type":"testing",{ }}.
  • Added multiple unit tests to cover most of the code paths to all classes inside BotBuilder.Dialogs. Some paths couldn't be covered due to limitations.
  • Renamed RecognizerTest to RecognizerTests.

Testing

The following image shows the code coverage of this namespace.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner February 7, 2025 16:51
@github-actions github-actions bot added ML: Core Tags changes to core libraries ML: Tests Tags changes to tests labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ML: Core Tags changes to core libraries ML: Tests Tags changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sw-joelmut