Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in azure backup schedule and retention reports #2883

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

nilgupta6
Copy link
Contributor

@nilgupta6 nilgupta6 commented Jan 30, 2025

Summary

Explain your changes, so people looking at the PR know what and why, the code changes are the how.

The ARG query being used in azure backup schedule and retention reports was not working fine.
Changed join to leftouter. Initially all data was not coming, with change in join all data is coming

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

image

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

testing done using branch code
https://ms.portal.azure.com/?feature.workbookGalleryBranch=dev_nilgupta_MABScheduleReportsBugFix#view/Microsoft_Azure_BCDRCenter/AbcCenterMenuBlade/~/reports

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@nilgupta6 nilgupta6 requested a review from a team as a code owner January 30, 2025 05:27
@nilgupta6 nilgupta6 merged commit 76ef59e into master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants