bug fix in azure backup schedule and retention reports #2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explain your changes, so people looking at the PR know what and why, the code changes are the how.
The ARG query being used in azure backup schedule and retention reports was not working fine.
Changed join to leftouter. Initially all data was not coming, with change in join all data is coming
Screenshots
If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).
It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.
Validation
Validate your changes using one or more of the testing methods.
Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!
testing done using branch code
https://ms.portal.azure.com/?feature.workbookGalleryBranch=dev_nilgupta_MABScheduleReportsBugFix#view/Microsoft_Azure_BCDRCenter/AbcCenterMenuBlade/~/reports
Checklist
When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.