Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Online experimentation analysis] Sort experiment dropdown by analysis's start time (iteration) #2891

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

QIU-Shuo
Copy link
Contributor

@QIU-Shuo QIU-Shuo commented Feb 4, 2025

Summary

  • Experiment dropout currently sort experiments by end time, which in cases like the second iteration end earlier than the first iteration (due to different duration settings), it will makes iteration 1 comes first in the drop down.
  • Fixed by sorting them in analysis start time.

Screenshots

image

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@QIU-Shuo QIU-Shuo requested a review from a team as a code owner February 4, 2025 18:26
@QIU-Shuo QIU-Shuo changed the title [Online experimentation analysis] Sort experiment dropdown by allocation id [Online experimentation analysis] Sort experiment dropdown by analysis's start time (iteration) Feb 6, 2025
QIU-Shuo and others added 3 commits February 11, 2025 17:50
…t Analysis.workbook


remove latestanalysistime

Co-authored-by: David Hall <davidhall@microsoft.com>
@QIU-Shuo QIU-Shuo merged commit 49e223c into master Feb 11, 2025
4 checks passed
@QIU-Shuo QIU-Shuo deleted the qiushuo/dev2 branch February 11, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants