-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to specifying position using position_column parameter #6825
base: master
Are you sure you want to change the base?
Conversation
Thanks for your interest in LightGBM. To set some expectations for how things work here:
|
@microsoft-github-policy-service agree |
@jameslamb can you take a look at this PR? I added test, but it currently breaks for some gpu builds (perhaps because gpu is not deterministic?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I took it of draft since you said it's ready for review.
Before I help with the build errors, I'd like @metpavel or @shiyu1994 to look and give you some feedback on the design. This is a significant ABI-breaking change, I'd like them to comment on:
- whether this functionality is worth it
- whether this could be done without breaking LightGBM's ABI
#5929 introduces a method for treatment of position bias, but it had limited options of specifying the position column (.position file or numpy array), uou can't have position column as a part of your train file.
In contrast, you can specify queries and weights with arguments "query_column" and "weight_column", this will make LightGBM load these columns from the train file directly.
This PR adds support for loading position column from file.