Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[#6877] Bot is not accepting v2 tokens from Bot Framework Emulator - Single Tenant Bots #6879

Merged

Conversation

JhontSouth
Copy link
Collaborator

#Fixes #6877

Description

This PR adds support for every possible token issuer version in Emulator authentication.

Specific Changes

  • Added 3 new valid token issuers in token emulator validation.
  • Added unit tests to check IsTokenFromEmulator performance.

Testing

The following image shows the new unit tests working.
image

@JhontSouth JhontSouth added the Automation: Parity with js The PR needs to be ported to JS label Jan 13, 2025
@JhontSouth JhontSouth requested a review from a team as a code owner January 13, 2025 14:38
@tracyboehrer tracyboehrer merged commit 8476cc0 into main Jan 14, 2025
4 of 9 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/add-token-versions-support-emulator-ST branch January 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot is not accepting v2 tokens from Bot Framework Emulator - Single Tenant Bots
2 participants