Allow silo/bindflt to be turned off via an annotation #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
This should fix regression microsoft#1699 Signed-off-by: June Rhodes <jrhodes@redpoint.games>
|
@hach-que added comment to the github issue you opened here #1699 (comment) . |
|
We haven't received further engagement on the response in github issue here #1699 (comment). We do not want to provide an annotation to switch back to job object design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix regression #1699, but I haven't built the full Kubernetes/containerd/hcsshim stack myself and tested it manually.
To turn off silo/bindflt on a job container, set the pod annotation
microsoft.com/hostprocess-no-silo: true.