Add spans and drop large size high volume logs to trace level #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiashok
force-pushed
the
reduceLogging
branch
from
3a1ff7b to
66723f6
Compare
|
cc @helsaawy |
kiashok
force-pushed
the
reduceLogging
branch
2 times, most recently
from
8d797b3 to
cf3c671
Compare
helsaawy
requested changes
Feb 15, 2024
kiashok
force-pushed
the
reduceLogging
branch
from
cf3c671 to
bbc5765
Compare
anmaxvl
reviewed
Feb 28, 2024
helsaawy
reviewed
Mar 6, 2024
Pushed new changes to address this. |
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
helsaawy
approved these changes
Mar 7, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds spans and drops debug logs to trace logs for large size high volume debug logs (bridge send, bridge receive, request read request and request write response traces). These logs carry the payload and incoming/outgoing message fields which cause the message column to be between 1000-4500 bytes. But since these logs are helpful for connectivity issues, it would be helpful to add spans and drop to trace level.