Add the ability to retry when looking for hot added device nodes #2040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main issues to solve when hot adding devices in the UVM:
Given that our existing support for assigned devices attempts to handle devices in a very device- and vendor- generic way, there is a race condition between when we hot add devices to the UVM for the first time during container creation and when the /dev nodes have been created. We attempt to minimize this by adding retry logic for when we try to find related /dev nodes.
This does not entirely solve our problems, since there could be a case where we find only a subset of the desired /dev nodes and return. However, for our current testing and use cases 500ms seems to be enough to capture all /dev nodes. We should investigate alternatives to this approach.