Handle empty layers in dmverity-vhd #2317
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see a bug where getting hashes for an image which includes a layer that does nothing (such as
chmod
-ing files which already have those permissions) causes a layer hash which is a blank string.The root cause is that when checking for layers in the image, we treat
TarReader.Next()
returning anio.EOF
as not a tar file rather than a valid but empty tar file, therefore we don't attempt to generate a hash for it